Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

use dpctl for trigonometric functions in dpnp#1545

Merged
antonwolfy merged 13 commits intomasterIntelPython/dpnp:masterfrom
trigonometric_dpctl_to_dpnpIntelPython/dpnp:trigonometric_dpctl_to_dpnpCopy head branch name to clipboard
Sep 8, 2023
Merged

use dpctl for trigonometric functions in dpnp#1545
antonwolfy merged 13 commits intomasterIntelPython/dpnp:masterfrom
trigonometric_dpctl_to_dpnpIntelPython/dpnp:trigonometric_dpctl_to_dpnpCopy head branch name to clipboard

Conversation

@vtavana
Copy link
Contributor

@vtavana vtavana commented Aug 29, 2023

The PR changes the implementation of dpnp.arccos, dpnp.arcsin, dpnp.arctan, dpnp.arctan2, and dpnp.tan. These functions now invoke oneapi::mkl::vm implementation from pybind11 extension of OneMKL VM if possible or uses dpctl.tensor implementation if not.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Aug 29, 2023
@vtavana vtavana marked this pull request as ready for review August 29, 2023 22:19
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Aug 30, 2023
View reviewed changes
dpnp/dpnp_algo/dpnp_algo.pxd Show resolved Hide resolved
tests/test_umath.py Show resolved Hide resolved
tests/third_party/cupy/math_tests/test_trigonometric.py Show resolved Hide resolved
tests/test_umath.py Show resolved Hide resolved
tests/test_sycl_queue.py Show resolved Hide resolved
tests/test_umath.py Show resolved Hide resolved
dpnp/dpnp_iface_trigonometric.py Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Aug 30, 2023
View reviewed changes
tests/test_mathematical.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Aug 30, 2023
View reviewed changes
tests/test_mathematical.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Aug 31, 2023
View reviewed changes
dpnp/dpnp_algo/dpnp_elementwise_common.py Show resolved Hide resolved
vlad-perevezentsev
vlad-perevezentsev reviewed Aug 31, 2023
View reviewed changes
tests/test_mathematical.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @vtavana

@antonwolfy antonwolfy merged commit 4df273c into master Sep 8, 2023
@antonwolfy antonwolfy deleted the trigonometric_dpctl_to_dpnp branch September 8, 2023 12:25
antonwolfy added a commit that referenced this pull request Sep 12, 2023
@antonwolfy
Corrected description for gh-1545
bee7869
antonwolfy added a commit that referenced this pull request Sep 12, 2023
@antonwolfy
Update change log due to 2024.0 release (#1555)
4813810 
* Updated change log towards 2024.0 release

* Added gh-1543

* Corrected description for gh-1545
This was referenced Sep 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev left review comments

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vtavana vtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vtavana @vlad-perevezentsev @antonwolfy
Morty Proxy This is a proxified and sanitized view of the page, visit original site.