Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Implemented dpnp.hstack() and dpnp.atleast_1d() functions.#1544

Merged
antonwolfy merged 10 commits intomasterIntelPython/dpnp:masterfrom
implement_hstackIntelPython/dpnp:implement_hstackCopy head branch name to clipboard
Sep 6, 2023
Merged

Implemented dpnp.hstack() and dpnp.atleast_1d() functions.#1544
antonwolfy merged 10 commits intomasterIntelPython/dpnp:masterfrom
implement_hstackIntelPython/dpnp:implement_hstackCopy head branch name to clipboard

Conversation

@npolina4
Copy link
Contributor

Implemented dpnp.hstack() and dpnp.atleast_1d() functions.
Added tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023

View rendered docs @ https://intelpython.github.io/dpnp/index.html

dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
tests/test_arraymanipulation.py Outdated Show resolved Hide resolved
tests/test_arraymanipulation.py Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
tests/test_arraymanipulation.py Show resolved Hide resolved
tests/test_arraymanipulation.py Outdated Show resolved Hide resolved
tests/test_arraymanipulation.py Outdated Show resolved Hide resolved
tests/test_arraymanipulation.py Outdated Show resolved Hide resolved
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the coverage of dpnp/dpnp_iface_manipulation.py is decreased by 1.18 %

dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @npolina4

@antonwolfy antonwolfy merged commit 80eb738 into master Sep 6, 2023
@antonwolfy antonwolfy deleted the implement_hstack branch September 6, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.