Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Leverage dpctl.tensor.expand_dims()/swapaxes() implementation#1532

Merged
vlad-perevezentsev merged 12 commits intomasterIntelPython/dpnp:masterfrom
dpctl_manipulationIntelPython/dpnp:dpctl_manipulationCopy head branch name to clipboard
Aug 23, 2023
Merged

Leverage dpctl.tensor.expand_dims()/swapaxes() implementation#1532
vlad-perevezentsev merged 12 commits intomasterIntelPython/dpnp:masterfrom
dpctl_manipulationIntelPython/dpnp:dpctl_manipulationCopy head branch name to clipboard

Conversation

@vlad-perevezentsev
Copy link
Contributor

This PR modifies dpnp.expand_dims and dpnp.swapaxes implementations to use dpctl.tensor.expand_dims() and dpctl.tensor.swapaxes() instead of dpnp implementations. updates the tests for them and adds swapaxes method for dpnp_array.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

View rendered docs @ https://intelpython.github.io/dpnp/index.html

dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
tests/third_party/cupy/manipulation_tests/test_dims.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
tests/third_party/cupy/linalg_tests/test_eigenvalue.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_algo/dpnp_algo_manipulation.pxi Show resolved Hide resolved
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you @vlad-perevezentsev

@vlad-perevezentsev vlad-perevezentsev merged commit 57e7359 into master Aug 23, 2023
@vlad-perevezentsev vlad-perevezentsev deleted the dpctl_manipulation branch August 23, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.