Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[MAINT] Fix Windows CI with 2025.1.0 compiler#2034

Merged
ndgrigorian merged 2 commits intomasterIntelPython/dpctl:masterfrom
fix-windows-ci-failure-2025.1IntelPython/dpctl:fix-windows-ci-failure-2025.1Copy head branch name to clipboard
Mar 31, 2025
Merged

[MAINT] Fix Windows CI with 2025.1.0 compiler#2034
ndgrigorian merged 2 commits intomasterIntelPython/dpctl:masterfrom
fix-windows-ci-failure-2025.1IntelPython/dpctl:fix-windows-ci-failure-2025.1Copy head branch name to clipboard

Conversation

@ndgrigorian
Copy link
Collaborator

After the release of 2025.1.0 compiler, Windows CI broke when building with 2025.0.4 and testing on 2025.1.0

This PR works around the problem by installing the 2025.1.0 compiler in the environment when building

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian ndgrigorian force-pushed the fix-windows-ci-failure-2025.1 branch 2 times, most recently from 68097b8 to f5425b2 Compare March 28, 2025 22:35
…ith 2025.1.0

Build with 2025.1.0 as a work-around
@ndgrigorian ndgrigorian force-pushed the fix-windows-ci-failure-2025.1 branch from f5425b2 to 7ad8972 Compare March 28, 2025 22:53
@github-actions
Copy link

github-actions bot commented Mar 28, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

coveralls commented Mar 28, 2025

Coverage Status

coverage: 86.752%. remained the same
when pulling 745ec43 on fix-windows-ci-failure-2025.1
into c5d18f4 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_73 ran successfully.
Passed: 894
Failed: 2
Skipped: 154

1 similar comment
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_73 ran successfully.
Passed: 894
Failed: 2
Skipped: 154

.github/workflows/conda-package.yml Show resolved Hide resolved
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_74 ran successfully.
Passed: 894
Failed: 2
Skipped: 154

@ndgrigorian ndgrigorian requested a review from antonwolfy March 30, 2025 16:14
@ndgrigorian ndgrigorian merged commit 63f5129 into master Mar 31, 2025
75 checks passed
@ndgrigorian ndgrigorian deleted the fix-windows-ci-failure-2025.1 branch March 31, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.