Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix logic to computing value of release Sphinx variable#1685

Merged
oleksandr-pavlyk merged 1 commit intomasterIntelPython/dpctl:masterfrom
fix-version-logic-in-confIntelPython/dpctl:fix-version-logic-in-confCopy head branch name to clipboard
May 17, 2024
Merged

Fix logic to computing value of release Sphinx variable#1685
oleksandr-pavlyk merged 1 commit intomasterIntelPython/dpctl:masterfrom
fix-version-logic-in-confIntelPython/dpctl:fix-version-logic-in-confCopy head branch name to clipboard

Conversation

@oleksandr-pavlyk
Copy link
Contributor

Presently the code was not ready to version to not have "+" separator in the version string. This change make the code more robust, and should fix the broken documentation build.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Presently the code was not ready to version to not have "+"
separator in the version string. This change make the code
more robust.
@github-actions
Copy link

github-actions bot commented May 17, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.971%. remained the same
when pulling 24678f2 on fix-version-logic-in-conf
into ee1ee10 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_2 ran successfully.
Passed: 890
Failed: 15
Skipped: 91

@oleksandr-pavlyk oleksandr-pavlyk merged commit 6639eae into master May 17, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-version-logic-in-conf branch May 17, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.