Fix reduction contig impl offset handling#1458
Merged
oleksandr-pavlyk merged 6 commits intomasterIntelPython/dpctl:masterfrom Oct 27, 2023
fix-reduction-contig_impl-offset-handlingIntelPython/dpctl:fix-reduction-contig_impl-offset-handlingCopy head branch name to clipboard
Merged
Fix reduction contig impl offset handling#1458oleksandr-pavlyk merged 6 commits intomasterIntelPython/dpctl:masterfrom fix-reduction-contig_impl-offset-handlingIntelPython/dpctl:fix-reduction-contig_impl-offset-handlingCopy head branch name to clipboard
oleksandr-pavlyk merged 6 commits intomasterIntelPython/dpctl:masterfrom
fix-reduction-contig_impl-offset-handlingIntelPython/dpctl:fix-reduction-contig_impl-offset-handlingCopy head branch name to clipboard
Conversation
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1458/index.html |
Collaborator
|
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_68 ran successfully. |
|
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_69 ran successfully. |
The optimization should not use max-work-group-size, to allow RT some of the SLM memory.
|
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_70 ran successfully. |
ndgrigorian
approved these changes
Oct 27, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies computation of typed pointer to take offsets into account in reduction implementations for contiguous inputs.
It also adds tests which would fail before this change