Removed superfluous barrier, moved comment, formatted kernel#1450
Merged
oleksandr-pavlyk merged 1 commit intomasterIntelPython/dpctl:masterfrom Oct 23, 2023
remove-barrier-in-accumulators-implIntelPython/dpctl:remove-barrier-in-accumulators-implCopy head branch name to clipboard
Merged
Removed superfluous barrier, moved comment, formatted kernel#1450oleksandr-pavlyk merged 1 commit intomasterIntelPython/dpctl:masterfrom remove-barrier-in-accumulators-implIntelPython/dpctl:remove-barrier-in-accumulators-implCopy head branch name to clipboard
oleksandr-pavlyk merged 1 commit intomasterIntelPython/dpctl:masterfrom
remove-barrier-in-accumulators-implIntelPython/dpctl:remove-barrier-in-accumulators-implCopy head branch name to clipboard
Conversation
Collaborator
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1450/index.html |
|
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_44 ran successfully. |
ndgrigorian
approved these changes
Oct 23, 2023
Collaborator
ndgrigorian
left a comment
There was a problem hiding this comment.
LGTM, good catch @oleksandr-pavlyk
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies
inclusive_scan_rec_local_scan_krnkernel in"accumulatros.hpp".It removed superfluous barrier, formats code for readability, and moves a comment while updating it slightly.