Fix host_task dependency not being passed to repeat 1d#1430
Merged
ndgrigorian merged 1 commit intomasterIntelPython/dpctl:masterfrom Oct 6, 2023
repeat-comp-ht-depends-fixIntelPython/dpctl:repeat-comp-ht-depends-fixCopy head branch name to clipboard
Merged
Fix host_task dependency not being passed to repeat 1d#1430ndgrigorian merged 1 commit intomasterIntelPython/dpctl:masterfrom repeat-comp-ht-depends-fixIntelPython/dpctl:repeat-comp-ht-depends-fixCopy head branch name to clipboard
ndgrigorian merged 1 commit intomasterIntelPython/dpctl:masterfrom
repeat-comp-ht-depends-fixIntelPython/dpctl:repeat-comp-ht-depends-fixCopy head branch name to clipboard
Conversation
1d variant of repeat was not passed host task event dependency for allocating shapes and strides on the device. This caused sporadic segfaults, where the kernel would attempt to access unallocated device data.
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1430/index.html |
Collaborator
|
Array API standard conformance tests for dpctl=0.15.1dev0=py310ha25a700_6 ran successfully. |
oleksandr-pavlyk
approved these changes
Oct 6, 2023
Contributor
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
👍 for catching this. LGTM!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in repeat where host_task event dependencies for allocating shapes and strides on the device were not always being passed to the kernel, which could cause the program to crash.
See this CI run