Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Use cmake_minimum_required with min...max#1424

Merged
oleksandr-pavlyk merged 1 commit intomasterIntelPython/dpctl:masterfrom
address-cmake-warningsIntelPython/dpctl:address-cmake-warningsCopy head branch name to clipboard
Sep 28, 2023
Merged

Use cmake_minimum_required with min...max#1424
oleksandr-pavlyk merged 1 commit intomasterIntelPython/dpctl:masterfrom
address-cmake-warningsIntelPython/dpctl:address-cmake-warningsCopy head branch name to clipboard

Conversation

@oleksandr-pavlyk
Copy link
Contributor

Use cmake_minumum_required(VERSION min_version...policy_version FATAL_ERROR).

Also update from using find_package(PythonExtensions) to find_package(Python COMPONENTS ...).

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 85.777%. remained the same when pulling b528b10 on address-cmake-warnings into 5bd924e on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.15.0rc3=py310ha25a700_2 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk merged commit b4aabe4 into master Sep 28, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the address-cmake-warnings branch September 28, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.