Update Docker hub with latest tags using Github Actions#26
Update Docker hub with latest tags using Github Actions#26AndresGuzman-Ballen merged 2 commits intomasterIntelPython/container-images:masterfrom feature/docker_update_tag_pushIntelPython/container-images:feature/docker_update_tag_pushCopy head branch name to clipboard
Conversation
|
It looks good. Creating a separate file is appropriate. You can't put this in ci.yml because ci.yml is triggered by PR and commit, while you want to trigger on pushing a tag. You will have to merge this and push a tag to test it. You also need to add your dockerhub credentials as secrets so secrets.DOCKER_LOGIN_USERNAME will be defined. |
publish.yml
Outdated
| id: meta | ||
| uses: docker/metadata-action@98669ae865ea3cffbcbaa878cf57c20bbf1c6c38 | ||
| with: | ||
| images: my-docker-hub-namespace/my-docker-hub-repository |
There was a problem hiding this comment.
@rscohn2 whoops; this should be intelpython/intelpython3_core. Should it be:
images:
- intelpython/intelpython3_core
- intelpython/intelpython3_full
There was a problem hiding this comment.
The old script pushed multiple tags for the same image. If the github tag is 2017.0.0-1, then the docker tag would be 2017.0.0-1, 2017.0, and latest. Looking at the documentation for the metadata-action, I think it will push 2017.0.0-1 and latest. The semver option https://github.com/docker/metadata-action#semver can extract the major.minor tag automatically, but our tags are not semver because of the -1 on the end. Choices are:
- stop tagging with major.minor. this is easiest and probably ok.
- manually put in the tags for every commit
- generate the tags by using the template processor to generate publish.ytml
- when the conda label is 2017.0.0-1, tag the repo with 2017.0.1
There was a problem hiding this comment.
@rscohn2 I think option 1 is best as well. There shouldn't be a 2017.0 tag if there's a chance it would have to be updated because of a CVE fix. Users can just rely on 'latest' and the snapshot itself (major.min.patch-build)
a54ec87 to
624249a
Compare
624249a to
dff42cd
Compare
|
@rscohn2 should I be able to see the new Docker containers by now: https://hub.docker.com/repository/docker/intelpython/intelpython3_core/tags?page=1&ordering=last_updated ? I pushed the tags right after merging the changes. |
|
The publish work flow is not running. You can see that by clicking on actions at the top: https://github.com/IntelPython/container-images/actions The workflow files should be in .github/workflows. Move it there and and push a new tag and it should run. |
@rscohn2 In addition to what you told me, I used this as a guide as well: https://docs.github.com/en/actions/guides/publishing-docker-images.
Does the PR look fine to you? Or is all this within the context of .github/workflows/ci.yml? I don't know if the commands used within the documentation applies solely to modifying ci.yml or if it also works in publish.yml.