You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Change the field type in nk_style_slider and nk_style_scrollbar to nk_bool.
I would rather not do this. Not only there are way more int fields with bool semantics like these two, there is simply no other use of nk_bool type anywhere in the style structs (EDIT: I think I found one somewhere). If you want these two changed, you should probably also change other similar fields elsewhere [...]
I may missing something, but I’m not entirely sure why this issue is being generalized to such a broad scope in the discussion. [...] broadening the problem to all similar cases, the conclusion naturally becomes that fixing it would be complex and risky. To me, this feels like a conceptual trap.
Those were the only ones that we had the code coverage to catch.
^ Those are the ones I was able to quickly find. There are probably more.
I personally do NOT want to change any of this. It can cause more issues like #812 and this isn't affecting any new code anyway. I gave many reasons under #883 why changing any of those struct fields is risky.
I'm only reporting this for the sake of documenting. I will not be doing anything about it myself, and would suggest everyone else to ignore it, at least for now.
This is a follow up from #883
Nuklear/src/nuklear.h
Line 4642 in 25f33c8
Nuklear/src/nuklear.h
Line 5038 in 25f33c8
Nuklear/src/nuklear.h
Line 5134 in 25f33c8
Nuklear/src/nuklear.h
Line 5359 in 25f33c8
Nuklear/src/nuklear.h
Line 5741 in 25f33c8
^ Those are the ones I was able to quickly find. There are probably more.
I personally do NOT want to change any of this. It can cause more issues like #812 and this isn't affecting any new code anyway. I gave many reasons under #883 why changing any of those struct fields is risky.
I'm only reporting this for the sake of documenting. I will not be doing anything about it myself, and would suggest everyone else to ignore it, at least for now.
Edit: related to: #183 ; #185