This repository was archived by the owner on Oct 4, 2023. It is now read-only.
closed file in upload_from_path#56
Merged
jacob-pascual merged 1 commit intomasterImgur/imgurpython:masterfrom Jan 22, 2016
unknown repositoryCopy head branch name to clipboard
Merged
closed file in upload_from_path#56jacob-pascual merged 1 commit intomasterImgur/imgurpython:masterfrom unknown repositoryCopy head branch name to clipboard
jacob-pascual merged 1 commit intomasterImgur/imgurpython:masterfrom
unknown repositoryCopy head branch name to clipboard
Conversation
The file no longer remains open after calling upload_from_path(). This would previously throw warnings.
|
Came here to report (and possibly fix) the same problem. Glad to see there is a PR open. @jasdev - Can we get a response for this PR? Would be very nice to have this warning removed. |
Contributor
|
@thrasr Hey! I don't actually work at Imgur anymore, so I can't merge this :/ Maybe @jacobgreenleaf can help? |
jacob-pascual
pushed a commit
that referenced
this pull request
Jan 22, 2016
…file closed file in upload_from_path
Contributor
|
I will upload this to PIP later. Thanks @r-hughes |
|
👍 Thanks guys =D |
Author
|
No problem. I'll send you the bill. |
|
I'm still getting the ResourceWarning with the PyPI version (1.1.6, uploaded 2015-04-23). @jacobgreenleaf could you upload the fixed version? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file no longer remains open after calling upload_from_path(). This would previously throw warnings.
This fixes issues #45 and #52.