This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Use property decorator where possible#42
Open
ueg1990 wants to merge 1 commit intoImgur:masterImgur/imgurpython:masterfrom
Open
Use property decorator where possible#42ueg1990 wants to merge 1 commit intoImgur:masterImgur/imgurpython:masterfrom
ueg1990 wants to merge 1 commit intoImgur:masterImgur/imgurpython:masterfrom
Conversation
|
I disagree with using getter functions or properties there. Properties are a nice way of changing/extending "variable" behaviour but if the behaviour is that of a normal variable, there is no need for that. I'm mainly commenting to see if you have an argument against my current opinion (also I'm not working for or am I in any way associated with Imgur) :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More Pythonic way of controlling access to instance variables.
From https://docs.python.org/2/howto/descriptor.html:
"The property() builtin helps whenever a user interface has granted attribute access and then subsequent changes require the intervention of a method."