Use class delete_tmpfiles flag in _run_xmlsec#931
Open
henrikek wants to merge 2 commits intoIdentityPython:masterIdentityPython/pysaml2:masterfrom
Open
Use class delete_tmpfiles flag in _run_xmlsec#931henrikek wants to merge 2 commits intoIdentityPython:masterIdentityPython/pysaml2:masterfrom
henrikek wants to merge 2 commits intoIdentityPython:masterIdentityPython/pysaml2:masterfrom
Conversation
Author
|
Is it possible to get this PR merged so it can be included in the next release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue of not deleting temporary files in windows to support running xmlsec1 as a subprocess in windows.
What your changes do and why you chose this solution
With this PR it is possible to use config parameter "delete_tmpfiles": False if os.name == 'nt' else True
#863