Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Jun 12, 2021. It is now read-only.

Use per client usage rules#110

Open
nsklikas wants to merge 1 commit intoIdentityPython:developIdentityPython/oidcendpoint:developfrom
nsklikas:feature-per-client-usage-rulesnsklikas/oidcendpoint:feature-per-client-usage-rulesCopy head branch name to clipboard
Open

Use per client usage rules#110
nsklikas wants to merge 1 commit intoIdentityPython:developIdentityPython/oidcendpoint:developfrom
nsklikas:feature-per-client-usage-rulesnsklikas/oidcendpoint:feature-per-client-usage-rulesCopy head branch name to clipboard

Conversation

@nsklikas
Copy link
Contributor

@nsklikas nsklikas commented Apr 21, 2021

The current code would overwrite the per client usage_rules. E.g.:

# The grant created here will take the usage_rules defined in the client
sid = endpoint_context.session_manager.create_session(
    ..., 
    token_usage_rules=endpoint_context.authz.usage_rules(auth_req.get("client_id")
)
# This calls endpoint_context.authz(...), which would overwrite the usage_rules (with the 
# global ones)
endpoint_context.endpoint["authorization"].authz_part2(auth_req, sid)

This PR fixes this behaviour.

@nsklikas nsklikas requested review from angelakis and rohe April 21, 2021 09:51
@rohe
Copy link
Contributor

rohe commented Apr 21, 2021

I'm working on a oidc-op version that includes oidcendpoint which will make the oidcendpoint package vanish.
I've applied your changes to the oidc-op branch (incl_oidcendpoint) I'm working on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rohe rohe Awaiting requested review from rohe

@angelakis angelakis Awaiting requested review from angelakis

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nsklikas @rohe
Morty Proxy This is a proxified and sanitized view of the page, visit original site.