Fix sub_mirror_public documentation#458
Open
jonathanperret wants to merge 1 commit intoIdentityPython:masterIdentityPython/SATOSA:masterfrom
Open
Fix sub_mirror_public documentation#458jonathanperret wants to merge 1 commit intoIdentityPython:masterIdentityPython/SATOSA:masterfrom
sub_mirror_public documentation#458jonathanperret wants to merge 1 commit intoIdentityPython:masterIdentityPython/SATOSA:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The documentation in
README.mdsays that thesub_mirror_subjectconfiguration option for the OIDC frontend will cause the backend'ssubto be reflected to the client. But the option is actually calledsub_mirror_publicin the code. Settingsub_mirror_subjecthas no effect.Solution
Fix the option name in
README.md.