This repository was archived by the owner on Jun 1, 2023. It is now read-only.
'keys' to 'key_conf' #58
Merged
Conversation
…n Configuration instance. Bumped version.
peppelinux
approved these changes
Dec 17, 2021
Member
peppelinux
left a comment
There was a problem hiding this comment.
let's add a clear message that's it's a btreaking change. Isn't it?
Contributor
Author
|
Is it a breaking change ? |
Member
|
Great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'keys' attribute in configuration file becomes 'key_conf' attribute in Configuration instance.
The reason for this change comes from using the oidcmsg definitions of Configuration as a subclass of dict.
dict already has a method called keys and this caused a conflict.
Bumped version.