This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Include oidcservice in OidcRP#34
Merged
rohe merged 19 commits intodevelopIdentityPython/JWTConnect-Python-OidcRP:developfrom May 11, 2021
incl_oidcserviceIdentityPython/JWTConnect-Python-OidcRP:incl_oidcserviceCopy head branch name to clipboard
Merged
Include oidcservice in OidcRP#34rohe merged 19 commits intodevelopIdentityPython/JWTConnect-Python-OidcRP:developfrom incl_oidcserviceIdentityPython/JWTConnect-Python-OidcRP:incl_oidcserviceCopy head branch name to clipboard
rohe merged 19 commits intodevelopIdentityPython/JWTConnect-Python-OidcRP:developfrom
incl_oidcserviceIdentityPython/JWTConnect-Python-OidcRP:incl_oidcserviceCopy head branch name to clipboard
Conversation
Contributor
Author
|
The CI will fail because of the dependency on OidcMsg version 1.3 which isn't out yet. |
peppelinux
approved these changes
Apr 15, 2021
rohe
commented
Apr 26, 2021
Contributor
Author
rohe
left a comment
There was a problem hiding this comment.
Nah, should really be
srv = client.client_get('service', 'end_session')
Member
|
Fixed here: |
…ct-Python-OidcRP into incl_oidcservice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a massive change since it encompasses moving the whole OidcService package into OidcRP.
It means that the JWTConnect stack now are composed of three parts instead of four which makes some things much easier.
One reason for doing this was that OidcRP really didn't contain much more then a number of RP examples.
As this wasn't enough this version also supports the new persistent storage model.
Furthermore in OidcService we had some circular references.
One more critical then others: service->service_context->service->..
This didn't work well with the new persistent storage model.
So I got rid of it by introducing a top layer (the entity.Entity class) and then provide those modules that need access to services or the service_context with functions they can call to get access to them.
With this release OidcService will be marked as archived and will not be updated anymore.