Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Issuer instances need to have the same httpc_params specification as …#168

Merged
jschlyter merged 1 commit intomainIdentityPython/JWTConnect-Python-CryptoJWT:mainfrom
httpc_paramIdentityPython/JWTConnect-Python-CryptoJWT:httpc_paramCopy head branch name to clipboard
Oct 1, 2024
Merged

Issuer instances need to have the same httpc_params specification as …#168
jschlyter merged 1 commit intomainIdentityPython/JWTConnect-Python-CryptoJWT:mainfrom
httpc_paramIdentityPython/JWTConnect-Python-CryptoJWT:httpc_paramCopy head branch name to clipboard

Conversation

@rohe
Copy link
Contributor

@rohe rohe commented Oct 1, 2024

…the KeyJar they belong to.

At least that should be the default.

@rohe rohe requested a review from jschlyter October 1, 2024 16:09
@codecov
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.21%. Comparing base (1e79713) to head (ef150b6).
Report is 61 commits behind head on main.

Files with missing lines Patch % Lines
src/cryptojwt/key_jar.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   76.22%   76.21%   -0.02%     
==========================================
  Files          44       44              
  Lines        4745     4746       +1     
  Branches     1000     1000              
==========================================
  Hits         3617     3617              
- Misses        823      824       +1     
  Partials      305      305              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jschlyter jschlyter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires merge of #166 to pass tests

@jschlyter jschlyter merged commit f18448c into main Oct 1, 2024
@jschlyter jschlyter deleted the httpc_param branch October 1, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.