Avoid library() in test files #741
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
flying-sheep
requested changes
Nov 13, 2023
hadley
reviewed
Nov 14, 2023
| expect_is(skipped_stack[[1]], 'call') | ||
| # See discussion in #741 about using inherits() here and not | ||
| # expect_type(., "language") or expect_true(is.call(.)) or expect_mode(., "call") | ||
| expect_true(inherits(skipped_stack[[1]], 'call')) |
There was a problem hiding this comment.
I think you could make this test more clear by making it more explicit:
expect_equal(skipped_stack[[1]], quote(f(1)))Or even:
expect_equal(skipped_stack, list(quote(f(1)), quote(stop(x))))That illustrates a subtle problem somewhere in the stack because if you print skipped_stack you see:
[[1]]
f(1)
[[2]]
function(x) stop(x)
Because the srcref is out of sync with the actual contents of the element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes tests less hermetic by creating permanent side effects that survive the test file.
Also remove deprecated
expect_is()in anticipation of upgrading to {testthat} 3rd edition.