Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Migrate from JDK 8 to JDK 17#104

Draft
Copilot wants to merge 2 commits intomasterHtmlUnit/htmlunit-cssparser:masterfrom
copilot/migrate-project-to-jdk-17HtmlUnit/htmlunit-cssparser:copilot/migrate-project-to-jdk-17Copy head branch name to clipboard
Draft

Migrate from JDK 8 to JDK 17#104
Copilot wants to merge 2 commits intomasterHtmlUnit/htmlunit-cssparser:masterfrom
copilot/migrate-project-to-jdk-17HtmlUnit/htmlunit-cssparser:copilot/migrate-project-to-jdk-17Copy head branch name to clipboard

Conversation

Copy link

Copilot AI commented Dec 29, 2025

Updates project to target JDK 17 as the minimum required Java version.

Changes

  • pom.xml: Updated maven.compiler.source and maven.compiler.target from 8 to 17
  • pom.xml: Updated maven-enforcer-plugin to require Java 17 (previously 1.8.0)
  • .github/dependabot.yml: Removed JDK 8-specific checkstyle version constraint

All existing code and dependencies are compatible with JDK 17 without modification.

Original prompt

Migration to JDK 17

Migrate the htmlunit-cssparser project from JDK 8 to JDK 17.

Changes Required

  1. Update pom.xml:

    • Change maven.compiler.source from 8 to 17 (line 20)
    • Change maven.compiler.target from 8 to 17 (line 21)
    • Update the maven-enforcer-plugin configuration to require Java 17 instead of 1.8.0 (line 63)
  2. Update GitHub Actions workflows (if any):

    • Check .github/workflows/ directory for any workflow files that specify Java versions
    • Update any Java setup actions to use Java 17
  3. Review code compatibility:

    • Ensure all code is compatible with JDK 17
    • Check for any deprecated APIs that need to be updated
    • Verify that all dependencies are compatible with JDK 17

Specific File Changes

pom.xml (lines 20-21):

<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>

pom.xml (lines 62-64):

<requireJavaVersion>
    <version>17</version>
</requireJavaVersion>

Testing Requirements

  • Ensure all tests pass with JDK 17
  • Verify that the build completes successfully
  • Check that generated artifacts work correctly with JDK 17

This pull request was created from Copilot chat.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: rbri <2544132+rbri@users.noreply.github.com>
Copilot AI changed the title [WIP] Migrate htmlunit-cssparser project from JDK 8 to JDK 17 Migrate from JDK 8 to JDK 17 Dec 29, 2025
Copilot AI requested a review from rbri December 29, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.