Reflect changes to URL.searchParams back to URL#377
Closed
cdalexndr wants to merge 7 commits intoHtmlUnit:masterHtmlUnit/htmlunit:masterfrom
Closed
Reflect changes to URL.searchParams back to URL#377cdalexndr wants to merge 7 commits intoHtmlUnit:masterHtmlUnit/htmlunit:masterfrom
cdalexndr wants to merge 7 commits intoHtmlUnit:masterHtmlUnit/htmlunit:masterfrom
Conversation
update master
update from base repo
Update from htmlunit/master
Member
|
As always many thanks fr the contribution. Will have a look at the others during the next days. Btw: it will be really great if we can use your real name for the author tag |
Member
|
Hi, It will be great if you can have a look at my changes and maybe make a new pr with more test cases for this area (and maybe fixes also). And again thanks a lot for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to
URL.searchParamsreflect back to original url.Depends on: #375, or else test fails with
cannot find functionerror