Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Implementation of @import and @media rules wrong and incomplete #360

Copy link
Copy link
@fdanek

Description

@fdanek
Issue body actions

The current implementations of the @import and @media rules are incomplete and partly wrong.

CSSImportRule
The main problem here is the wrong implementation of CSSImportRule.styleSheet. Currently it returns the importing style sheet. The correct behavior would be to return the imported style sheet.

Besides this there are only some minor formatting problems in the returned text.

CSSMediaRule
The main problem here is that the implementation especially of the super classes CSSConditionRule and CSSGroupingRule is not complete. Example: as CSSGroupingRule.cssRules is missing you are not able to access the CSS rules inside the media rule.

I will provide unit tests for these points as a pull request.
Additionally I will have a look if I can provide fixes for some of the points. But especially regarding the main problem of CSSImportRule I am not very optimistic...

Reactions are currently unavailable

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.