Update to HtmlUnit 2.50#37
Merged
asbjornu merged 8 commits intoHtmlUnit:mainHtmlUnit/NHtmlUnit:mainfrom Jun 4, 2021
AlexanderStromer:mainCopy head branch name to clipboard
Merged
Update to HtmlUnit 2.50#37asbjornu merged 8 commits intoHtmlUnit:mainHtmlUnit/NHtmlUnit:mainfrom AlexanderStromer:mainCopy head branch name to clipboard
asbjornu merged 8 commits intoHtmlUnit:mainHtmlUnit/NHtmlUnit:mainfrom
AlexanderStromer:mainCopy head branch name to clipboard
Conversation
Member
|
Awesome! 👏🏼 Could you please add a GitHub Action workflow as well, so we get some automated tests that prove everything is in working order? 🙏🏼 |
Contributor
Author
|
done, also did some badge-work for the readme |
Co-authored-by: Asbjørn Ulsberg <asbjorn@ulsberg.no>
asbjornu
approved these changes
Jun 4, 2021
Member
|
Thank you so much for this, @AlexanderStromer! 🙏🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested with #34 I took it into my own hands and updated. It works fine on my side. If also ok for you, consider updating NuGet as well, thx
Had to change the tests, since wikipedia has some SSL handshake issue when requesting the page (also did not work with v2.19)