Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add exercises #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
Loading
from
Open

Conversation

thebladehit
Copy link

I created two exercises in Excercise.ua.md and created a folder Solutions with two files which contain solutions to exercises.

Solutions/1-showelem.js Outdated Show resolved Hide resolved
Exercise.ua.md Outdated Show resolved Hide resolved
@thebladehit
Copy link
Author

I replaced the tab with two spaces and I change ? to if() statment.

Exercise.ua.md Outdated Show resolved Hide resolved
Exercise.ua.md Outdated Show resolved Hide resolved
Exercise.ua.md Outdated Show resolved Hide resolved
Exercise.ua.md Outdated Show resolved Hide resolved
Exercise.ua.md Outdated Show resolved Hide resolved
Exercise.ua.md Outdated Show resolved Hide resolved
Solutions/1-showelem.js Outdated Show resolved Hide resolved
Solutions/2-powloop.js Outdated Show resolved Hide resolved
@tshemsedinov
Copy link
Member

Add Exercises folder with automated tests like here: https://github.com/HowProgrammingWorks/Iteration/tree/master/Exercises

@thebladehit
Copy link
Author

Add autotest.

@thebladehit thebladehit closed this Nov 7, 2022
@thebladehit
Copy link
Author

If something wrong. I'll do one more pull request because I accidentally closed it.

@tshemsedinov tshemsedinov reopened this Nov 15, 2022
Copy link
Member

@tshemsedinov tshemsedinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove .idea/ from PR
  • Do not commit package-lock and package.json
    LGTM

@tshemsedinov
Copy link
Member

@thebladehit
Copy link
Author

thebladehit commented Nov 15, 2022

Did what you had said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.