Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on May 14, 2024. It is now read-only.

Conversation

@Ann-Grabetski
Copy link

No description provided.

Week1/homework/app.js Outdated Show resolved Hide resolved
Week1/homework/app.js Outdated Show resolved Hide resolved
Week1/homework/app.js Outdated Show resolved Hide resolved
const booksList = document.createElement(`ul`);
document.body.insertBefore(booksList, document.body.childNodes[2]);

for (const book of booksArray) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

}
};

for (const book of booksArray) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to remove debugging code like this loop before submitting your homework.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

original_language.appendChild(original_languageContent);
};

for (const book of booksArray) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this solution to add the images works it is not what was asked for in the instructions. Please read 1.7 and 1.8 again. And implement it like it is written there.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Ann-Grabetski
Copy link
Author

Hi @wilgert ,
I have finished the implementation of your feedback to JS2 Week1 homework. Have a look when you will have a time, please.
Have an amazing evening!

@Ann-Grabetski
Copy link
Author

Hi @wilgert ,
I also have added a new JS2 Week2 homework. I thought it will be in a separate page, but looks like everything from JavaScript2 will be here. Waiting for your feedback!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.