This repository was archived by the owner on May 14, 2024. It is now read-only.
js2 homework week2 #188
Closed
js2 homework week2 #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohni
reviewed
Nov 26, 2018
rohni
left a comment
There was a problem hiding this comment.
Good job, it works, and the results are correct.
🥇
| @@ -1,11 +1,105 @@ | ||
| 'use strict'; | ||
| { | ||
| const bookTitles = [ |
There was a problem hiding this comment.
This should be on its own branch, not master.
As a result of doing this correctly, I would not be seeing all the week1 diffs in week2's homework. 😄
| const numbers = [1, 2, 3, 4]; | ||
|
|
||
| // Add your code here | ||
| const numbers = [1, 2, 3, 4]; |
There was a problem hiding this comment.
Nice job here.
Did you run this? Because it should have given you an error, you are defining numbers twice as a constant.
There was a problem hiding this comment.
Have you thought about using arrow functions (=>) here? They can make things more readable, and less typing. 😛
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.