Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on May 14, 2024. It is now read-only.

Conversation

@Shvan1
Copy link

@Shvan1 Shvan1 commented May 5, 2019

No description provided.

@Shvan1 Shvan1 changed the title Add files via upload First JS Homework May 5, 2019
Copy link
Contributor

@marcianoviereck marcianoviereck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general the homework looks good, but there are some remarks here and there.

And can you split up the homework in separate files?

For all the following exercises create a new .js file. Try to find a proper name for each file or make a small comment about what it does inside for future reference.

app.js Outdated Show resolved Hide resolved
app.js Outdated Show resolved Hide resolved
app.js Outdated Show resolved Hide resolved
app.js Outdated Show resolved Hide resolved
app.js Outdated Show resolved Hide resolved
app.js Outdated Show resolved Hide resolved
app.js Outdated Show resolved Hide resolved
app.js Outdated Show resolved Hide resolved
app.js Show resolved Hide resolved
@wouterkleijn
Copy link
Contributor

@marcianoviereck I noticed @Shvan1 made some edits. Is this okay now or does he need to make some further changes? Thanks!

@marcianoviereck
Copy link
Contributor

@wouterkleijn not all the feedback is resolved yet, as far as I can see in the 'files changed'. There are still some remarks of me which have not been fixed yet.

Copy link
Contributor

@marcianoviereck marcianoviereck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all my comments have been adressed yet, as far as I can see. Can you still make those changes?

app.js Show resolved Hide resolved
I have split the questions and corrected some mistakes that figured out by Marciano.
@Shvan1 Shvan1 changed the title First JS Homework JS1 Homework/Week2 May 25, 2019
Copy link
Contributor

@marcianoviereck marcianoviereck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change request, for the rest the homework looks good!
If you fix that last one, then the homework is approved.

app.js Outdated Show resolved Hide resolved
question 6.6 is edited.
Copy link
Contributor

@marcianoviereck marcianoviereck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice, thanks for fixing the homework! It's approved now :)

@NoerGitKat NoerGitKat closed this Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.