-
Notifications
You must be signed in to change notification settings - Fork 255
JS1 Homework/Week2 #111
JS1 Homework/Week2 #111
Conversation
marcianoviereck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general the homework looks good, but there are some remarks here and there.
And can you split up the homework in separate files?
For all the following exercises create a new .js file. Try to find a proper name for each file or make a small comment about what it does inside for future reference.
Week3 Homeworkof JS
JS Homework-week 3
|
@marcianoviereck I noticed @Shvan1 made some edits. Is this okay now or does he need to make some further changes? Thanks! |
|
@wouterkleijn not all the feedback is resolved yet, as far as I can see in the 'files changed'. There are still some remarks of me which have not been fixed yet. |
marcianoviereck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not all my comments have been adressed yet, as far as I can see. Can you still make those changes?
I have split the questions and corrected some mistakes that figured out by Marciano.
marcianoviereck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last change request, for the rest the homework looks good!
If you fix that last one, then the homework is approved.
question 6.6 is edited.
marcianoviereck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nice, thanks for fixing the homework! It's approved now :)
No description provided.