Issue branch 1#6
Open
gparlakov wants to merge 8 commits intoHTBox:masterHTBox/allReady-processing:masterfrom
gparlakov:issue-branch-1gparlakov/allReady-processing:issue-branch-1Copy head branch name to clipboard
Open
Issue branch 1#6gparlakov wants to merge 8 commits intoHTBox:masterHTBox/allReady-processing:masterfrom gparlakov:issue-branch-1gparlakov/allReady-processing:issue-branch-1Copy head branch name to clipboard
gparlakov wants to merge 8 commits intoHTBox:masterHTBox/allReady-processing:masterfrom
gparlakov:issue-branch-1gparlakov/allReady-processing:issue-branch-1Copy head branch name to clipboard
Conversation
Add the necessary packages Todo add sedn grid auth
2. Add a unit test project 3. Comment code until it works ... 4. Simple test works
2. Add unit tests for plain text, html, invalid message, missing environment variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
I did some work on this issue as I see it.
I've copied over the code for the most part. My addition was using the AzureWebJobsSendGridApiKey instead of the Authentication:SendGrid:ApiKey as I was not able to make it work with the latter and also the former is the canonical way.
I've added a test project also with a few tests for the green path and for exception cases.
For TraceWriter: Instead of mocking I just implemented the abstract and gathered the events for assertions