Create UnkownEvent and UnkownObject classes for unkown CDP events #24
Merged
HMaker merged 2 commits intoHMaker:masterHMaker/python-cdp:masterfrom Oct 3, 2025
RazorBest:add-unknown-eventsRazorBest/python-cdp:add-unknown-eventsCopy head branch name to clipboard
Merged
Create UnkownEvent and UnkownObject classes for unkown CDP events #24HMaker merged 2 commits intoHMaker:masterHMaker/python-cdp:masterfrom RazorBest:add-unknown-eventsRazorBest/python-cdp:add-unknown-eventsCopy head branch name to clipboard
HMaker merged 2 commits intoHMaker:masterHMaker/python-cdp:masterfrom
RazorBest:add-unknown-eventsRazorBest/python-cdp:add-unknown-eventsCopy head branch name to clipboard
Conversation
Owner
|
Thanks, it's really usefull to avoid breaking CDP clients due missing event types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CDP updates periodically, and sometimes, new events are added. Python-cdp throws an error for these kind of events, because there isn't a corresponding class for them. This, of course, can be solved by updating the repository with the new CDP specification.
However, this makes tools that might have python-cdp as a dependency, unusable, after a while. Especially when these events are generated frequently. However, those tools probably don't need the newly added events. They might still be functional.
This PR makes python-cdp treat the case where a CDP event is unkown. It creates a generic class called UnkownEvent that can be used like any other event class. It can contain instances of UnkownObject, depending on the structure of the json.
Additionally, tools that use python-cdp can read the new events by working with instances of UnknownEvent.
After this, python-cdp can potentially continue to work for newer versions of cdp, without syncing the repo with the spec. This, however, doesn't solve the case where existing CDP events or objects are updated.