Add support for method on instance as function name with '.' separator syntax #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freedomofkeima
approved these changes
Dec 28, 2020
|
Sorry for ghosting. I've worked with this more and I don't think it's a good pattern. Specifically, the python extension for the serverless framework implements similar behavior, except that it will go into nested modules, but not into nested python objects. I think this library handles that. Either way I've found that a more standard approach just forwards the invocation from a handler.py type file to the desired method, if anyone is interested in doing something similar with grouping lambdas' handling logic in a python class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows providing
instance.methodto the -f flag to indicate that the function is nested in another object.It could also allow multiple levels of nesting as it loops into the '.' separated names to resolve the object.
Resolves #73