fix: cannot send mail with providers using differing smtp from and user fields #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for jade-gingersnap-11da58 pending review.Visit the deploys page to approve it
|
cosmickylenny
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common mailing providers like Mailjet expect an API key as the SMTP user, and the SMTP from address to be a valid email address. Atlas was incorrectly using the
helper.setFromfunction with non-Gmail providers by assuming that SMTP_USER would be an email address, resulting in mail send failing silently without an error.This PR exposes an additional config option to the user to optionally set SMTP_FROM, in order to handle mailing services where SMTP auth user and SMTP from address must contain different values.