Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

testing: remove btlr binary #8809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2022
Merged

testing: remove btlr binary #8809

merged 2 commits into from
Dec 16, 2022

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Dec 15, 2022

fixes #8805

@tmatsuo tmatsuo requested review from a team as code owners December 15, 2022 18:02
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 15, 2022
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Dec 15, 2022

cc @kurtisvg

Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on 3.10 testing everything seems good! Failure is unrelated to the change in this PR, Thank you Takashi!

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Dec 15, 2022

@dandhlee thanks for the review

It is a bit concerning to see the Python2.7 build seems to get stuck though.

@dandhlee
Copy link
Collaborator

The tests are now expected to take ~3 hours. I don't think it's stuck but just continuing to run. The tests should be done within an hour or two.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Dec 16, 2022

Yeah Python 2.7 build got timeout, a little concerning.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Dec 16, 2022

But Python 3.7 and 3.8 builds look fine (despite failure).

I'd admin merge, but defer the decision to the python sample team.

@dandhlee
Copy link
Collaborator

All failures seem unrelated to this PR's content. Admin merging.

@dandhlee dandhlee merged commit 323dd14 into main Dec 16, 2022
@dandhlee dandhlee deleted the remove-btlr-binary branch December 16, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Policy violation Binary Artifacts
4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.