Fix ml_engine tests #850
Merged
Fix ml_engine tests #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't get the py35 tests to run locally @jonparrott . I get the following error: https://gist.github.com/elibixby/ac829c83972c4fb9f5a3c8ff16d87e9f |
|
@elibixby travis seems fine with py35, might be your local install. Merging. |
|
The failure was in the slow tests. I've kicked off https://jenkins.on2flixcloud.tv/view/python/job/python-doc-samples/731/ to verify they work in Jenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename tf_records -> examples everywhere, since TFRecords is technically a misnomer (or rather the name for the file container format for a number of tf.train.Example proto [or really any proto])
Move both JSON and EXAMPLE tests to a new model, so that they share a common expected output
Hopefully fix python 3 compat