App Engine Cloud Storage Client Sample #793
Conversation
…n-docs-samples into appengine-cloud-storage-client
| import logging | ||
| import os | ||
|
|
||
| import cloudstorage as gcs |
| # [END imports] | ||
|
|
||
| # [START retries] | ||
| my_default_retry_params = gcs.RetryParams( |
There was a problem hiding this comment.
instead of having a temporary variable, just pass this right into set_default_retry_params.
| 'BUCKET_NAME', app_identity.get_default_gcs_bucket_name()) | ||
|
|
||
| self.response.headers['Content-Type'] = 'text/plain' | ||
| self.response.write( |
There was a problem hiding this comment.
use .format instead of string concatenation.
| self.list_bucket_directory_mode(bucket) | ||
| self.response.write('\n\n') | ||
|
|
||
| except Exception, e: |
There was a problem hiding this comment.
Don't catch broad exceptions. In this case, it's better to just not handle errors and let them bubble up to the user.
| The retry_params specified in the open call will override the default | ||
| retry params for this particular file handle. | ||
|
|
||
| Args: |
There was a problem hiding this comment.
Just remove this args section.
| def create_file(self, filename): | ||
| """Create a file. | ||
|
|
||
| The retry_params specified in the open call will override the default |
There was a problem hiding this comment.
Move this to a comment above write_retry_commands.
| self.response.write('Creating file %s\n' % filename) | ||
|
|
||
| write_retry_params = gcs.RetryParams(backoff_factor=1.1) | ||
| gcs_file = gcs.open( |
There was a problem hiding this comment.
Does this support with? If so, switch to that.
…n-docs-samples into appengine-cloud-storage-client
| from oauth2client.client import GoogleCredentials | ||
| import webapp2 | ||
|
|
||
|
|
||
| # The bucket that will be used to list objects. | ||
| BUCKET_NAME = '<your-bucket-name>' | ||
|
|
||
| # The filename for an object to be uploaded. |
There was a problem hiding this comment.
I'd actually prefer this to just be in line in the code below.
| credentials = GoogleCredentials.get_application_default() | ||
| storage = discovery.build('storage', 'v1', credentials=credentials) | ||
|
|
||
|
|
||
| class MainPage(webapp2.RequestHandler): | ||
| def upload_object(self, bucket, filename): |
There was a problem hiding this comment.
use file_obj instead of filename
| def get(self): | ||
| response = storage.objects().list(bucket=BUCKET_NAME).execute() | ||
| string_io_file = StringIO.StringIO() | ||
| string_io_file.write('Hello World!') |
There was a problem hiding this comment.
You can just pass this string into the StringIO constructor.
…n-docs-samples into appengine-cloud-storage-client
|
@ryanmats let me know if you have these passing locally. |
|
@jonparrott yep, they are passing locally |
Moved over code from https://cloud.google.com/appengine/docs/python/googlecloudstorageclient/app-engine-cloud-storage-sample to python-docs-samples , added a test, and fixed style issues.