Hackathon/Codelab vision sample #788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-docs-samples into hackathon-vision-sample
…n-docs-samples into hackathon-vision-sample
|
Still TODO: use Jinja2 for HTML output, README instructions |
…n-docs-samples into hackathon-vision-sample
theacodes
reviewed
Feb 15, 2017
appengine/flexible/vision/main.py
Outdated
| @@ -0,0 +1,127 @@ | ||
| # Copyright 2015 Google Inc. All Rights Reserved. |
appengine/flexible/vision/main.py
Outdated
| from google.cloud import vision | ||
|
|
||
|
|
||
| CLOUD_STORAGE_BUCKET = '<your-storage-bucket>' |
There was a problem hiding this comment.
Use os.environ and env_variables in app.yaml? (or do you have a good reason for this?)
…n-docs-samples into hackathon-vision-sample
|
will add test(s) soon |
|
@ryanmats this looks good, I'd just prefer we put it under |
theacodes
approved these changes
Feb 16, 2017
|
Please create a bug for yourself to add tests. |
…n-docs-samples into hackathon-vision-sample
… students follow along on the README during the hackathon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A work in progress for EDU hackathons / Codelab.