BigQuery - REST samples for adding labels. #764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm looking into the Travis failure. Strange that it worked on my machine. I guess maybe because Travis is using a service account and I was using |
|
I'll add a scope argument to the |
yep, that should do it. |
theacodes
suggested changes
Jan 20, 2017
| }) | ||
|
|
||
| # Check the response for errors. | ||
| if response.status_code != 200: |
There was a problem hiding this comment.
use response.raise_for_status().
| project_id = default_project_id | ||
|
|
||
| # Send a PATCH request to add or modify a label. | ||
| session = google.auth.transport.requests.AuthorizedSession(credentials) |
There was a problem hiding this comment.
put session in the auth section (two lines above)
| @@ -0,0 +1,84 @@ | ||
| #!/usr/bin/env python |
There was a problem hiding this comment.
Would it make sense to combine these into one single file named labels?
There was a problem hiding this comment.
Yes, it would. Combined.
4570bbe to
2b18184
Compare
theacodes
approved these changes
Jan 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See docs: https://cloud.google.com/bigquery/docs/labeling-datasets
These samples uses raw REST calls because adding labels is not yet supported in the cloud client libraries.