Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(issue-7478): resolving missing modules & versions #7583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 14, 2022
Merged

Conversation

pattishin
Copy link
Contributor

Description

Fixes #7478

Fusion: https://source.cloud.google.com/results/invocations/dd66b6e0-62fb-40c6-b05a-1301c18ebbbd/targets

Steps to re-create error:

Using appengine as an example, but should apply to other affected samples.

  1. Use locally or cloud shell and navigate to the sample folder and simply install requirements
pip3 install -r requirements.txt
pip3 install -r requirements-test.txt
  1. You should see the same error logs like so after executing the following:
python3 main.py

Error:
Screen Shot 2022-03-10 at 9 47 45 PM

  1. Verify this PR no longer produces those missing module errors and for appengine - verify the tests are passing locally.

Screen Shot 2022-03-10 at 9 48 27 PM

Note: You'll see varying versions for markupsafe are being installed. This is due to the varying Flask versions per sample
ref: pallets/flask#4455 (comment)

Checklist

@pattishin pattishin requested review from a team as code owners March 11, 2022 05:54
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 11, 2022
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! One minor change.

composer/airflow_1_samples/requirements.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dandhlee
Copy link
Collaborator

Addressing dependency issues, admin merging.

@dandhlee dandhlee merged commit aa47539 into main Mar 14, 2022
@dandhlee dandhlee deleted the bugfix/issue-7478 branch March 14, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

appengine.flexible.websockets.main_test: test_websocket failed
3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.