Updated Django Container Engine sample to use CloudSQL v2, sidecar co… #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntainer pod pattern, Django 1.10, and Deployment rather than ReplicationController
waprin
suggested changes
Jan 14, 2017
| # [END proxy_container] | ||
| # [START volumes] | ||
| volumes: | ||
| - name: cloudsql-oauth-credentials |
There was a problem hiding this comment.
where are these secrets created?
There was a problem hiding this comment.
bill and i just discussed this, will update on Tuesday
|
|
||
| 1. Create a project in the [Google Cloud Platform Console](https://console.cloud.google.com). | ||
| # Tutorial | ||
| See our [Django on Container Engine](https://cloud.google.com/python/django/container-engine) tutorial for instructions for setting up and deploying this sample application. |
There was a problem hiding this comment.
There's secrets in here but the tutorial I see now doesn't have secret anywhere?
There was a problem hiding this comment.
bill and i just discussed this, will update on Tuesday
…n-docs-samples into django-container-engine-update
waprin
approved these changes
Jan 17, 2017
theacodes
approved these changes
Jan 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntainer pod pattern, Django 1.10, and Deployment rather than ReplicationController
Tested this a number of times to make sure it works. Staged changes to the cloud.google.com tutorial at https://cloud-dot-devsite.googleplex.com/python/django/container-engine and will send that changelist for review once this code is merged.