Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

remove more rogue noxfiles #7095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 15, 2021
Merged

remove more rogue noxfiles #7095

merged 6 commits into from
Nov 15, 2021

Conversation

leahecole
Copy link
Collaborator

@leahecole leahecole commented Nov 11, 2021

Description

Removed 3 rogue noxfiles - 2 are no different than the default. The third is a dataflow one so I added a corresponding noxfile_config with the proper ignored python sessions. I exempted it from Type hints as well because this was written before we asked for them in our samples

@leahecole leahecole requested a review from a team November 11, 2021 21:25
@leahecole leahecole requested a review from a team as a code owner November 11, 2021 21:25
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 11, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2021
dataflow/encryption-keys/noxfile_config.py Outdated Show resolved Hide resolved
@leahecole leahecole added the automerge Merge the pull request once unit tests and other checks pass. label Nov 15, 2021
@leahecole leahecole merged commit c160107 into master Nov 15, 2021
@leahecole leahecole deleted the 310-tests branch November 15, 2021 19:06
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.