Django_cloudsql config edits #700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweaked a few placeholder names for variables users should change before testing/deploying. Also updated environment variable that changed because of flex beta 2.
waprin
reviewed
Dec 7, 2016
| } | ||
| } | ||
| # In the flexible environment, you connect to CloudSQL using a unix socket. | ||
| # Locally, you can use the CloudSQL proxy to proxy a localhost connection | ||
| # to the instance | ||
| DATABASES['default']['HOST'] = '/cloudsql/<your-cloudsql-connection-string>' | ||
| if os.getenv('GAE_APPENGINE_HOSTNAME'): | ||
| if os.getenv('GAE_INSTANCE'): |
There was a problem hiding this comment.
I think this change only makes sense if you switch it to env: flex, which we haven't done yet?
There was a problem hiding this comment.
Wow yes we have...was it broken before?
There was a problem hiding this comment.
not sure. Once I finish updating the tutorial I'm gonna go through it end-to-end to make sure it all works.
waprin
approved these changes
Dec 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaked a few placeholder names for variables users should change before testing/deploying. The tutorial is now going to ask them to create a non-root username/password. Also updated environment variable that changed because of flex beta 2.