Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: update samples for pap, unspecified -> inherited #6757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 4, 2021

Conversation

unforced
Copy link
Contributor

Updates samples in accord with public access prevention changes, changing unspecified to inherited.

@unforced unforced requested review from a team as code owners September 28, 2021 19:43
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 28, 2021
@snippet-bot
Copy link

snippet-bot bot commented Sep 28, 2021

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 28, 2021
@cojenco cojenco added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 29, 2021
@cojenco
Copy link
Contributor

cojenco commented Sep 29, 2021

@Breathtender Thanks for working on this! Instead of replacing the existing sample storage_set_public_access_prevention_unspecified.py, we want to create a new sample storage_set_public_access_prevention_inherited.py

Please refer to #6751

@shaffeeullah
Copy link
Contributor

@Breathtender Thanks for working on this! Instead of replacing the existing sample storage_set_public_access_prevention_unspecified.py, we want to create a new sample storage_set_public_access_prevention_inherited.py

Please refer to #6751

+1, thanks cathy! the unspecified sample test might have to be deleted to get all the tests passing. if so, that's okay. however, please keep the sample there for now, as it is linked from the public documentation.

thanks for working on this @Breathtender !

@unforced
Copy link
Contributor Author

This should be all ready, just waiting for googleapis/python-storage#603 to be released so that the tests can pass.

Copy link
Contributor

@nicain nicain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change requested

Aaron Gabriel Neyer and others added 2 commits September 29, 2021 16:15
@unforced unforced added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2021
@unforced unforced requested review from nicain and cojenco October 1, 2021 21:17
@unforced unforced removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 1, 2021
Copy link
Contributor

@nicain nicain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicain
Copy link
Contributor

nicain commented Oct 1, 2021

@leahecole python3.10 build is failing for the PR, with nox > Session py-3.10 failed: Python interpreter 3.10 not found.. Can you recommend a fix? 3.10 goes live Monday, correct?

Copy link
Contributor

@nicain nicain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@unforced unforced merged commit e90c44a into GoogleCloudPlatform:master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.