-
Notifications
You must be signed in to change notification settings - Fork 6.6k
fix: update samples for pap, unspecified -> inherited #6757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
@Breathtender Thanks for working on this! Instead of replacing the existing sample Please refer to #6751
|
+1, thanks cathy! the unspecified sample test might have to be deleted to get all the tests passing. if so, that's okay. however, please keep the sample there for now, as it is linked from the public documentation. thanks for working on this @Breathtender ! |
This should be all ready, just waiting for googleapis/python-storage#603 to be released so that the tests can pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change requested
storage/cloud-client/storage_set_public_access_prevention_inherited.py
Outdated
Show resolved
Hide resolved
…rited.py Co-authored-by: cojenco <cathyo@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@leahecole python3.10 build is failing for the PR, with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Updates samples in accord with public access prevention changes, changing unspecified to inherited.