Add comment about python runtime to Dockerfile #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to link to source of Docker image
theacodes
approved these changes
Nov 16, 2016
waprin
reviewed
Nov 16, 2016
| @@ -1,3 +1,7 @@ | ||
| # The Google App Engine python runtime is Debian Jessie with Python installed |
There was a problem hiding this comment.
Probably better not to say it's Jessie in case it changes underneath us and the comment becomes outdated, better just to link to it. Also while we're at it ,probably best to consistently capitalize Python and Github in prose. Finally, I think we still put license headers on Dockerfiles?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to link to source of Docker image