Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: add a comment to draw attention to using get_blob, not blob #5052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 9, 2020
Merged

fix: add a comment to draw attention to using get_blob, not blob #5052

merged 6 commits into from
Dec 9, 2020

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Dec 8, 2020 •
edited
Loading

There have been reports that perhaps blob and get_blob and there differences can be confusing to users. This attempts to bring in some context to popular samples to help clarify.

@crwilcox crwilcox requested review from a team as code owners December 8, 2020 21:47
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 8, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 8, 2020
@crwilcox crwilcox requested a review from frankyn December 8, 2020 22:00
@crwilcox
Copy link
Contributor Author

crwilcox commented Dec 8, 2020

@frankyn @sdspikes I have added a bit of documentation to two samples. This may be a bit much but thought we can hone in a bit.

@crwilcox crwilcox merged commit c55cd88 into master Dec 9, 2020
@crwilcox crwilcox deleted the clarify-get-blob branch December 9, 2020 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees

@tmatsuo tmatsuo

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crwilcox @frankyn @busunkim96 @tmatsuo
Morty Proxy This is a proxified and sanitized view of the page, visit original site.