Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix incorrect parameter name #4906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

wooong1130
Copy link
Contributor

@wooong1130 wooong1130 commented Oct 25, 2020

  • Fixes the problem with incorrect parameter name

Description

Fixes #4905

File "/user_code/main.py", line 42, in detect_text text_detection_response = vision_client.text_detection(source=image) TypeError: inner() missing 1 required positional argument: 'image'

I got this error message when I followed the tutorial
https://cloud.google.com/functions/docs/tutorials/ocr#functions-clone-sample-repository-python

/functions/ocr/app/main.py, line 42

text_detection_response = vision_client.text_detection(image=image)  

change parameter name "source" => "image"

Checklist

* Fixes the problem with incorrect parameter name
@wooong1130 wooong1130 requested review from ace-n, grant and a team as code owners October 25, 2020 12:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 26, 2020
@ace-n ace-n added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 26, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 26, 2020
Copy link

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wooong1130 thanks for the PR!

LGTM if tests pass. (Running them now.)

@ace-n ace-n added the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit c5bbdfd into GoogleCloudPlatform:master Oct 26, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2020
craiglabenz pushed a commit that referenced this pull request Nov 2, 2020
* Fixes the problem with incorrect parameter name

## Description

Fixes #4905 

<!-- Please be specific. Copying and pasting your invocation and the entire
output is often helpful. -->
> File "/user_code/main.py", line 42, in detect_text text_detection_response = vision_client.text_detection(source=image) TypeError: inner() missing 1 required positional argument: 'image'

I got this error message when I followed the tutorial
https://cloud.google.com/functions/docs/tutorials/ocr#functions-clone-sample-repository-python

<!-- Please provide the full path to the file, to avoid ambiguity -->
`
/functions/ocr/app/main.py, line 42 
`
<!-- A diff would be helpful; otherwise, a description -->
```
text_detection_response = vision_client.text_detection(image=image)  
```
change parameter name "source" => "image"




## Checklist
- [ ] I have followed [Sample Guidelines from AUTHORING_GUIDE.MD](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md)
- [ ] README is updated to include [all relevant information](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#readme-file)
- [ ] **Tests** pass:   `nox -s py-3.6` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#test-environment-setup))
- [ ] **Lint** pass:   `nox -s lint` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#test-environment-setup))
- [ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones)
- [ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones)
- [ ] Please **merge** this PR for me once it is approved.
- [ ] This sample adds a new sample directory, and I updated the [CODEOWNERS file](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/.github/CODEOWNERS) with the codeowners for this sample
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: inner() missing 1 required positional argument: 'image'
5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.