Update Kubernetes Deployment for django tutorial #4831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craiglabenz
pushed a commit
that referenced
this pull request
Nov 2, 2020
* Update Kubernetes Deployment for django tutorial * restore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes b/149717875 - Upgrades the Kubernetes Deployment file to the
apps/v1API version, which includes adding an appselectorfield.https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#creating-a-deployment
And fixes a syntax error where the
emptydirvolume type was set to null instead of the correct{}.Tested + verified the updated sample against the doc: https://cloud.google.com/python/django/kubernetes-engine#top_of_page
Checklist
nox -s py-3.6(see Test Environment Setup)nox -s lint(see Test Environment Setup)