Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

chore: only run 2.7 tests for GAE #3116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 27, 2020

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Mar 18, 2020

This runs 2.7 tests only for GAE Standard samples.

The second commit intentionally touched files in every directory to trigger CI. The real changes to the noxfiles and kokoro are in the first commit. I will revert the spurious License header commit before merging. :)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2020
@busunkim96 busunkim96 marked this pull request as ready for review March 19, 2020 16:34
@averikitsch
Copy link
Contributor

We probably don't need Py2.7 testing anymore and should remove all py2.7 GAE samples as well. @andrewsg

@andrewsg
Copy link
Member

We'll continue to offer Python 2 on GAE for a very long time, so we can't remove those samples yet. As for Py2 tests on platforms other than GAE, it would be helpful to me if we can continue to run them so we know when Py2 compatibility breaks, and then disable them piecemeal, but I understand if that is not possible.

At any rate, a large number of people run Py2 on our platform so we should keep that in mind.

@busunkim96
Copy link
Contributor Author

@andrewsg We're getting to drop 2.7 support and move to the microgenerator next quarter. We will be very clear when we drop 2.7 support (python_requires in setup.py, major version bumps, and notes in changelogs and READMEs). Continuing to run the Python 2 tests on all the samples prevents folks from using modern language features, so I think this is a good time.

Do others have thoughts? @GoogleCloudPlatform/python-samples-owners

Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the small deltas were intentional. I'm OK with skipping 2.7 in IoT Core.

appengine/flexible/django_cloudsql/mysite/settings.py Outdated Show resolved Hide resolved
@busunkim96
Copy link
Contributor Author

Removed the extra commit to trigger CI.

Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leahecole leahecole added the automerge Merge the pull request once unit tests and other checks pass. label Mar 27, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 307b032 into GoogleCloudPlatform:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.