-
Notifications
You must be signed in to change notification settings - Fork 6.6k
chore: only run 2.7 tests for GAE #3116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: only run 2.7 tests for GAE #3116
Conversation
We probably don't need Py2.7 testing anymore and should remove all py2.7 GAE samples as well. @andrewsg |
We'll continue to offer Python 2 on GAE for a very long time, so we can't remove those samples yet. As for Py2 tests on platforms other than GAE, it would be helpful to me if we can continue to run them so we know when Py2 compatibility breaks, and then disable them piecemeal, but I understand if that is not possible. At any rate, a large number of people run Py2 on our platform so we should keep that in mind. |
@andrewsg We're getting to drop 2.7 support and move to the microgenerator next quarter. We will be very clear when we drop 2.7 support (python_requires in setup.py, major version bumps, and notes in changelogs and READMEs). Continuing to run the Python 2 tests on all the samples prevents folks from using modern language features, so I think this is a good time. Do others have thoughts? @GoogleCloudPlatform/python-samples-owners |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the small deltas were intentional. I'm OK with skipping 2.7 in IoT Core.
Removed the extra commit to trigger CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This runs 2.7 tests only for GAE Standard samples.
The second commit intentionally touched files in every directory to trigger CI. The real changes to the noxfiles and kokoro are in the first commit. I will revert the spurious License header commit before merging. :)