"Hello Broken" python sample #2618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amples into hello-broken
…docs-samples into hello-broken
leahecole
requested changes
Dec 16, 2019
leahecole
approved these changes
Dec 19, 2019
|
Just double checking w/ other maintainers that we're cool with it only being py 3.6+ because of the f-strings before I merge |
grayside
approved these changes
Dec 20, 2019
|
@GoogleCloudPlatform/python-samples-owners - per our discussion in chat, we decided to merge this. One of us will follow up with the linked issue to ensure this problem doesn't occur. @dinagraves sorry for the delay, but thank you for inspiring a high quality conversation that definitely needed to happen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python sample for the Local Troubleshooting tutorial.
Includes a route that purposefully breaks for the tutorial.