Fixup sample for list_hmac_keys #2404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankyn
approved these changes
Sep 17, 2019
frankyn
reviewed
Sep 17, 2019
| @@ -29,14 +29,9 @@ def list_keys(project_id): | ||
| hmac_keys = storage_client.list_hmac_keys(project_id=project_id) | ||
| print('HMAC Keys:') | ||
| for hmac_key in hmac_keys: | ||
| print('The HMAC key metadata is:') | ||
| print('Key ID: {}'.format(hmac_key.id)) | ||
| print('Service Account Email: {}'.format( |
There was a problem hiding this comment.
Email is missing from the other samples. I missed that metadata field in Ruby and saw it was missing here as well. Only additional ask I have.
There was a problem hiding this comment.
Added to the other samples. Let me know if you see anything else!
frankyn
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix data printed to match canonical sample.