From 69874d9e14d540a1f1ea4b199dcef480ee08df07 Mon Sep 17 00:00:00 2001 From: mdejong3 <35782177+mdejong3@users.noreply.github.com> Date: Thu, 5 Sep 2019 12:50:43 -0700 Subject: [PATCH 01/13] Moving variable definitions inside methods Ensures that variable definitions are captured in the region tags, so they'll show up in the documentation --- iam/api-client/service_accounts.py | 41 ++++++++++++++++++++++-------- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/iam/api-client/service_accounts.py b/iam/api-client/service_accounts.py index f70e6024b2d..ca02519d85c 100644 --- a/iam/api-client/service_accounts.py +++ b/iam/api-client/service_accounts.py @@ -25,19 +25,19 @@ from google.oauth2 import service_account import googleapiclient.discovery -credentials = service_account.Credentials.from_service_account_file( - filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], - scopes=['https://www.googleapis.com/auth/cloud-platform']) - -service = googleapiclient.discovery.build( - 'iam', 'v1', credentials=credentials) - # [START iam_create_service_account] def create_service_account(project_id, name, display_name): """Creates a service account.""" - + # pylint: disable=no-member + credentials = service_account.Credentials.from_service_account_file( + filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], + scopes=['https://www.googleapis.com/auth/cloud-platform']) + + service = googleapiclient.discovery.build( + 'iam', 'v1', credentials=credentials) + service_account = service.projects().serviceAccounts().create( name='projects/' + project_id, body={ @@ -55,8 +55,15 @@ def create_service_account(project_id, name, display_name): # [START iam_list_service_accounts] def list_service_accounts(project_id): """Lists all service accounts for the current project.""" - + # pylint: disable=no-member + credentials = service_account.Credentials.from_service_account_file( + filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], + scopes=['https://www.googleapis.com/auth/cloud-platform']) + + service = googleapiclient.discovery.build( + 'iam', 'v1', credentials=credentials) + service_accounts = service.projects().serviceAccounts().list( name='projects/' + project_id).execute() @@ -71,9 +78,17 @@ def list_service_accounts(project_id): # [START iam_rename_service_account] def rename_service_account(email, new_display_name): """Changes a service account's display name.""" - + # First, get a service account using List() or Get() + credentials = service_account.Credentials.from_service_account_file( + filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], + scopes=['https://www.googleapis.com/auth/cloud-platform']) + + service = googleapiclient.discovery.build( + 'iam', 'v1', credentials=credentials) + resource = 'projects/-/serviceAccounts/' + email + # pylint: disable=no-member service_account = service.projects().serviceAccounts().get( name=resource).execute() @@ -94,6 +109,12 @@ def delete_service_account(email): """Deletes a service account.""" # pylint: disable=no-member + credentials = service_account.Credentials.from_service_account_file( + filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], + scopes=['https://www.googleapis.com/auth/cloud-platform']) + + service = googleapiclient.discovery.build( + 'iam', 'v1', credentials=credentials) service.projects().serviceAccounts().delete( name='projects/-/serviceAccounts/' + email).execute() From 2b9df10d5efcfef95e160f7853bc3ca4ebd3e3f7 Mon Sep 17 00:00:00 2001 From: mdejong3 <35782177+mdejong3@users.noreply.github.com> Date: Mon, 9 Sep 2019 09:38:04 -0700 Subject: [PATCH 02/13] Added region tags to capture imports --- iam/api-client/service_accounts.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/iam/api-client/service_accounts.py b/iam/api-client/service_accounts.py index ca02519d85c..99ff1ee7421 100644 --- a/iam/api-client/service_accounts.py +++ b/iam/api-client/service_accounts.py @@ -20,11 +20,18 @@ """ import argparse +# [START iam_create_service_account] +# [START iam_list_service_account] +# [START iam_rename_service_account] +# [START iam_delete_service_account] import os from google.oauth2 import service_account import googleapiclient.discovery - +# [END iam_create_service_account] +# [END iam_list_service_account] +# [END iam_rename_service_account] +# [END iam_delete_service_account] # [START iam_create_service_account] def create_service_account(project_id, name, display_name): From f75806d7a1ce1edb68ae8da9795231bfc32f0fe9 Mon Sep 17 00:00:00 2001 From: mdejong3 <35782177+mdejong3@users.noreply.github.com> Date: Mon, 9 Sep 2019 10:22:11 -0700 Subject: [PATCH 03/13] Moved variable definitions inside functions Moved the variable definitions inside the functions so they would be captured by the region tags --- iam/api-client/service_account_keys.py | 30 ++++++++++++++++++++------ 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/iam/api-client/service_account_keys.py b/iam/api-client/service_account_keys.py index b73227dd794..6554de1ea97 100644 --- a/iam/api-client/service_account_keys.py +++ b/iam/api-client/service_account_keys.py @@ -27,18 +27,20 @@ from google.oauth2 import service_account import googleapiclient.discovery -credentials = service_account.Credentials.from_service_account_file( - filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], - scopes=['https://www.googleapis.com/auth/cloud-platform']) -service = googleapiclient.discovery.build( - 'iam', 'v1', credentials=credentials) # [START iam_create_key] def create_key(service_account_email): """Creates a key for a service account.""" - + # pylint: disable=no-member + credentials = service_account.Credentials.from_service_account_file( + filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], + scopes=['https://www.googleapis.com/auth/cloud-platform']) + + service = googleapiclient.discovery.build( + 'iam', 'v1', credentials=credentials) + key = service.projects().serviceAccounts().keys().create( name='projects/-/serviceAccounts/' + service_account_email, body={} ).execute() @@ -50,8 +52,15 @@ def create_key(service_account_email): # [START iam_list_keys] def list_keys(service_account_email): """Lists all keys for a service account.""" - + # pylint: disable=no-member + credentials = service_account.Credentials.from_service_account_file( + filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], + scopes=['https://www.googleapis.com/auth/cloud-platform']) + + service = googleapiclient.discovery.build( + 'iam', 'v1', credentials=credentials) + keys = service.projects().serviceAccounts().keys().list( name='projects/-/serviceAccounts/' + service_account_email).execute() @@ -65,6 +74,13 @@ def delete_key(full_key_name): """Deletes a service account key.""" # pylint: disable=no-member + credentials = service_account.Credentials.from_service_account_file( + filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], + scopes=['https://www.googleapis.com/auth/cloud-platform']) + + service = googleapiclient.discovery.build( + 'iam', 'v1', credentials=credentials) + service.projects().serviceAccounts().keys().delete( name=full_key_name).execute() From 4947d0b72fce14941271f780a9e1118a50fff417 Mon Sep 17 00:00:00 2001 From: mdejong3 <35782177+mdejong3@users.noreply.github.com> Date: Mon, 9 Sep 2019 10:23:45 -0700 Subject: [PATCH 04/13] Added region tags to capture imports --- iam/api-client/service_account_keys.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/iam/api-client/service_account_keys.py b/iam/api-client/service_account_keys.py index 6554de1ea97..3eb8d1a31d1 100644 --- a/iam/api-client/service_account_keys.py +++ b/iam/api-client/service_account_keys.py @@ -22,12 +22,17 @@ """ import argparse +# [START iam_create_key] +# [START iam_list_keys] +# [START iam_delete_key] import os from google.oauth2 import service_account import googleapiclient.discovery - +# [END iam_create_key] +# [END iam_list_keys] +# [END iam_delete_key] # [START iam_create_key] def create_key(service_account_email): From 927a71fc3c35bae37cfb46ee4e780a3f4be6afbd Mon Sep 17 00:00:00 2001 From: mdejong3 <35782177+mdejong3@users.noreply.github.com> Date: Mon, 9 Sep 2019 10:24:48 -0700 Subject: [PATCH 05/13] Minor formatting adjustments --- iam/api-client/service_accounts.py | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/iam/api-client/service_accounts.py b/iam/api-client/service_accounts.py index 99ff1ee7421..9d04fee88da 100644 --- a/iam/api-client/service_accounts.py +++ b/iam/api-client/service_accounts.py @@ -28,6 +28,7 @@ from google.oauth2 import service_account import googleapiclient.discovery + # [END iam_create_service_account] # [END iam_list_service_account] # [END iam_rename_service_account] @@ -39,11 +40,11 @@ def create_service_account(project_id, name, display_name): # pylint: disable=no-member credentials = service_account.Credentials.from_service_account_file( - filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], - scopes=['https://www.googleapis.com/auth/cloud-platform']) + filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], + scopes=['https://www.googleapis.com/auth/cloud-platform']) service = googleapiclient.discovery.build( - 'iam', 'v1', credentials=credentials) + iam', 'v1', credentials=credentials) service_account = service.projects().serviceAccounts().create( name='projects/' + project_id, @@ -65,8 +66,8 @@ def list_service_accounts(project_id): # pylint: disable=no-member credentials = service_account.Credentials.from_service_account_file( - filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], - scopes=['https://www.googleapis.com/auth/cloud-platform']) + filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], + scopes=['https://www.googleapis.com/auth/cloud-platform']) service = googleapiclient.discovery.build( 'iam', 'v1', credentials=credentials) @@ -88,11 +89,11 @@ def rename_service_account(email, new_display_name): # First, get a service account using List() or Get() credentials = service_account.Credentials.from_service_account_file( - filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], - scopes=['https://www.googleapis.com/auth/cloud-platform']) + filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], + scopes=['https://www.googleapis.com/auth/cloud-platform']) service = googleapiclient.discovery.build( - 'iam', 'v1', credentials=credentials) + 'iam', 'v1', credentials=credentials) resource = 'projects/-/serviceAccounts/' + email @@ -117,11 +118,12 @@ def delete_service_account(email): # pylint: disable=no-member credentials = service_account.Credentials.from_service_account_file( - filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], - scopes=['https://www.googleapis.com/auth/cloud-platform']) + filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], + scopes=['https://www.googleapis.com/auth/cloud-platform']) service = googleapiclient.discovery.build( - 'iam', 'v1', credentials=credentials) + 'iam', 'v1', credentials=credentials) + service.projects().serviceAccounts().delete( name='projects/-/serviceAccounts/' + email).execute() From 926487963a372da0c269df0fbfa55dbeca878798 Mon Sep 17 00:00:00 2001 From: mdejong3 <35782177+mdejong3@users.noreply.github.com> Date: Mon, 9 Sep 2019 10:52:59 -0700 Subject: [PATCH 06/13] Removing whitespace from blank lines --- iam/api-client/service_accounts.py | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/iam/api-client/service_accounts.py b/iam/api-client/service_accounts.py index 9d04fee88da..98d66531952 100644 --- a/iam/api-client/service_accounts.py +++ b/iam/api-client/service_accounts.py @@ -37,12 +37,12 @@ # [START iam_create_service_account] def create_service_account(project_id, name, display_name): """Creates a service account.""" - + # pylint: disable=no-member credentials = service_account.Credentials.from_service_account_file( filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], scopes=['https://www.googleapis.com/auth/cloud-platform']) - + service = googleapiclient.discovery.build( iam', 'v1', credentials=credentials) @@ -63,12 +63,12 @@ def create_service_account(project_id, name, display_name): # [START iam_list_service_accounts] def list_service_accounts(project_id): """Lists all service accounts for the current project.""" - + # pylint: disable=no-member credentials = service_account.Credentials.from_service_account_file( filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], scopes=['https://www.googleapis.com/auth/cloud-platform']) - + service = googleapiclient.discovery.build( 'iam', 'v1', credentials=credentials) @@ -86,17 +86,17 @@ def list_service_accounts(project_id): # [START iam_rename_service_account] def rename_service_account(email, new_display_name): """Changes a service account's display name.""" - + # First, get a service account using List() or Get() credentials = service_account.Credentials.from_service_account_file( filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], scopes=['https://www.googleapis.com/auth/cloud-platform']) - + service = googleapiclient.discovery.build( 'iam', 'v1', credentials=credentials) - + resource = 'projects/-/serviceAccounts/' + email - + # pylint: disable=no-member service_account = service.projects().serviceAccounts().get( name=resource).execute() @@ -120,10 +120,10 @@ def delete_service_account(email): credentials = service_account.Credentials.from_service_account_file( filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], scopes=['https://www.googleapis.com/auth/cloud-platform']) - + service = googleapiclient.discovery.build( 'iam', 'v1', credentials=credentials) - + service.projects().serviceAccounts().delete( name='projects/-/serviceAccounts/' + email).execute() From 0880dbe6ebb0eecf72677344c459034b7cad398c Mon Sep 17 00:00:00 2001 From: mdejong3 <35782177+mdejong3@users.noreply.github.com> Date: Mon, 9 Sep 2019 11:02:37 -0700 Subject: [PATCH 07/13] Removing whitespace from blank lines --- iam/api-client/service_account_keys.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/iam/api-client/service_account_keys.py b/iam/api-client/service_account_keys.py index 3eb8d1a31d1..2da3ba93dd2 100644 --- a/iam/api-client/service_account_keys.py +++ b/iam/api-client/service_account_keys.py @@ -34,15 +34,16 @@ # [END iam_list_keys] # [END iam_delete_key] + # [START iam_create_key] def create_key(service_account_email): """Creates a key for a service account.""" - + # pylint: disable=no-member credentials = service_account.Credentials.from_service_account_file( filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], scopes=['https://www.googleapis.com/auth/cloud-platform']) - + service = googleapiclient.discovery.build( 'iam', 'v1', credentials=credentials) @@ -57,12 +58,12 @@ def create_key(service_account_email): # [START iam_list_keys] def list_keys(service_account_email): """Lists all keys for a service account.""" - + # pylint: disable=no-member credentials = service_account.Credentials.from_service_account_file( filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], scopes=['https://www.googleapis.com/auth/cloud-platform']) - + service = googleapiclient.discovery.build( 'iam', 'v1', credentials=credentials) @@ -82,7 +83,7 @@ def delete_key(full_key_name): credentials = service_account.Credentials.from_service_account_file( filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], scopes=['https://www.googleapis.com/auth/cloud-platform']) - + service = googleapiclient.discovery.build( 'iam', 'v1', credentials=credentials) From 4a5a7946e84cfebac69a9f0353b1213489917d64 Mon Sep 17 00:00:00 2001 From: mdejong3 <35782177+mdejong3@users.noreply.github.com> Date: Mon, 9 Sep 2019 11:04:04 -0700 Subject: [PATCH 08/13] Lint --- iam/api-client/service_accounts.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/iam/api-client/service_accounts.py b/iam/api-client/service_accounts.py index 98d66531952..21869b4ea1e 100644 --- a/iam/api-client/service_accounts.py +++ b/iam/api-client/service_accounts.py @@ -34,6 +34,7 @@ # [END iam_rename_service_account] # [END iam_delete_service_account] + # [START iam_create_service_account] def create_service_account(project_id, name, display_name): """Creates a service account.""" @@ -44,7 +45,7 @@ def create_service_account(project_id, name, display_name): scopes=['https://www.googleapis.com/auth/cloud-platform']) service = googleapiclient.discovery.build( - iam', 'v1', credentials=credentials) + 'iam', 'v1', credentials=credentials) service_account = service.projects().serviceAccounts().create( name='projects/' + project_id, @@ -70,7 +71,7 @@ def list_service_accounts(project_id): scopes=['https://www.googleapis.com/auth/cloud-platform']) service = googleapiclient.discovery.build( - 'iam', 'v1', credentials=credentials) + 'iam', 'v1', credentials=credentials) service_accounts = service.projects().serviceAccounts().list( name='projects/' + project_id).execute() From 574ac7dab23ea184ad1e7f623a845d32104bc5b8 Mon Sep 17 00:00:00 2001 From: mdejong3 <35782177+mdejong3@users.noreply.github.com> Date: Mon, 9 Sep 2019 11:19:52 -0700 Subject: [PATCH 09/13] Lint --- iam/api-client/service_accounts.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/iam/api-client/service_accounts.py b/iam/api-client/service_accounts.py index 21869b4ea1e..8073f7184ba 100644 --- a/iam/api-client/service_accounts.py +++ b/iam/api-client/service_accounts.py @@ -89,6 +89,7 @@ def rename_service_account(email, new_display_name): """Changes a service account's display name.""" # First, get a service account using List() or Get() + # pylint: disable=no-member credentials = service_account.Credentials.from_service_account_file( filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], scopes=['https://www.googleapis.com/auth/cloud-platform']) @@ -98,7 +99,6 @@ def rename_service_account(email, new_display_name): resource = 'projects/-/serviceAccounts/' + email - # pylint: disable=no-member service_account = service.projects().serviceAccounts().get( name=resource).execute() From a3a434cd17eb53d45ee9f9cc0398be7c3dc2bc20 Mon Sep 17 00:00:00 2001 From: mdejong3 <35782177+mdejong3@users.noreply.github.com> Date: Mon, 9 Sep 2019 11:27:26 -0700 Subject: [PATCH 10/13] Lint Solved redundancy between global "service_account" and local variable "service_account" in create_service_account and rename_service_account by changing the name of the local variable to "my_service_account" --- iam/api-client/service_accounts.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/iam/api-client/service_accounts.py b/iam/api-client/service_accounts.py index 8073f7184ba..4976997a8fa 100644 --- a/iam/api-client/service_accounts.py +++ b/iam/api-client/service_accounts.py @@ -47,7 +47,7 @@ def create_service_account(project_id, name, display_name): service = googleapiclient.discovery.build( 'iam', 'v1', credentials=credentials) - service_account = service.projects().serviceAccounts().create( + my_service_account = service.projects().serviceAccounts().create( name='projects/' + project_id, body={ 'accountId': name, @@ -56,8 +56,8 @@ def create_service_account(project_id, name, display_name): } }).execute() - print('Created service account: ' + service_account['email']) - return service_account + print('Created service account: ' + my_service_account['email']) + return my_service_account # [END iam_create_service_account] @@ -99,17 +99,17 @@ def rename_service_account(email, new_display_name): resource = 'projects/-/serviceAccounts/' + email - service_account = service.projects().serviceAccounts().get( + my_service_account = service.projects().serviceAccounts().get( name=resource).execute() # Then you can update the display name - service_account['displayName'] = new_display_name - service_account = service.projects().serviceAccounts().update( + my_service_account['displayName'] = new_display_name + my_service_account = service.projects().serviceAccounts().update( name=resource, body=service_account).execute() print('Updated display name for {} to: {}'.format( - service_account['email'], service_account['displayName'])) - return service_account + service_account['email'], my_service_account['displayName'])) + return my_service_account # [END iam_rename_service_account] From d044d50ab05a2791cc7b4545683ac7341b26dce4 Mon Sep 17 00:00:00 2001 From: mdejong3 <35782177+mdejong3@users.noreply.github.com> Date: Wed, 11 Sep 2019 13:40:33 -0700 Subject: [PATCH 11/13] Removing pylint tags --- iam/api-client/service_accounts.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/iam/api-client/service_accounts.py b/iam/api-client/service_accounts.py index 4976997a8fa..2ec5758ec74 100644 --- a/iam/api-client/service_accounts.py +++ b/iam/api-client/service_accounts.py @@ -39,7 +39,6 @@ def create_service_account(project_id, name, display_name): """Creates a service account.""" - # pylint: disable=no-member credentials = service_account.Credentials.from_service_account_file( filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], scopes=['https://www.googleapis.com/auth/cloud-platform']) @@ -65,7 +64,6 @@ def create_service_account(project_id, name, display_name): def list_service_accounts(project_id): """Lists all service accounts for the current project.""" - # pylint: disable=no-member credentials = service_account.Credentials.from_service_account_file( filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], scopes=['https://www.googleapis.com/auth/cloud-platform']) @@ -89,7 +87,6 @@ def rename_service_account(email, new_display_name): """Changes a service account's display name.""" # First, get a service account using List() or Get() - # pylint: disable=no-member credentials = service_account.Credentials.from_service_account_file( filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], scopes=['https://www.googleapis.com/auth/cloud-platform']) @@ -117,7 +114,6 @@ def rename_service_account(email, new_display_name): def delete_service_account(email): """Deletes a service account.""" - # pylint: disable=no-member credentials = service_account.Credentials.from_service_account_file( filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], scopes=['https://www.googleapis.com/auth/cloud-platform']) From 5fd2c2f93fe6ed90dec72a9d3e76bd20541fa8e1 Mon Sep 17 00:00:00 2001 From: mdejong3 <35782177+mdejong3@users.noreply.github.com> Date: Wed, 11 Sep 2019 13:41:04 -0700 Subject: [PATCH 12/13] Removing pylint tags --- iam/api-client/service_account_keys.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/iam/api-client/service_account_keys.py b/iam/api-client/service_account_keys.py index 2da3ba93dd2..d9017f669eb 100644 --- a/iam/api-client/service_account_keys.py +++ b/iam/api-client/service_account_keys.py @@ -39,7 +39,6 @@ def create_key(service_account_email): """Creates a key for a service account.""" - # pylint: disable=no-member credentials = service_account.Credentials.from_service_account_file( filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], scopes=['https://www.googleapis.com/auth/cloud-platform']) @@ -59,7 +58,6 @@ def create_key(service_account_email): def list_keys(service_account_email): """Lists all keys for a service account.""" - # pylint: disable=no-member credentials = service_account.Credentials.from_service_account_file( filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], scopes=['https://www.googleapis.com/auth/cloud-platform']) @@ -79,7 +77,6 @@ def list_keys(service_account_email): def delete_key(full_key_name): """Deletes a service account key.""" - # pylint: disable=no-member credentials = service_account.Credentials.from_service_account_file( filename=os.environ['GOOGLE_APPLICATION_CREDENTIALS'], scopes=['https://www.googleapis.com/auth/cloud-platform']) From ea50d1514a03e088e245f53fb3d6d184fcd1308c Mon Sep 17 00:00:00 2001 From: mdejong3 <35782177+mdejong3@users.noreply.github.com> Date: Wed, 11 Sep 2019 14:08:40 -0700 Subject: [PATCH 13/13] Update service_account to my_service_account --- iam/api-client/service_accounts.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/iam/api-client/service_accounts.py b/iam/api-client/service_accounts.py index 2ec5758ec74..895e02bb663 100644 --- a/iam/api-client/service_accounts.py +++ b/iam/api-client/service_accounts.py @@ -102,10 +102,10 @@ def rename_service_account(email, new_display_name): # Then you can update the display name my_service_account['displayName'] = new_display_name my_service_account = service.projects().serviceAccounts().update( - name=resource, body=service_account).execute() + name=resource, body=my_service_account).execute() print('Updated display name for {} to: {}'.format( - service_account['email'], my_service_account['displayName'])) + my_service_account['email'], my_service_account['displayName'])) return my_service_account # [END iam_rename_service_account]